Support Apple Silicon and Linux Arm64 targets #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvc94ch
approved these changes
Jul 20, 2023
Lohann
changed the title
|
DO NOT MERGE! I'm debugging why docker containers doesn't starts |
|
That's really odd.. building the connector using the target only works: cargo build -p rosetta-server-ethereum --release --target x86_64-unknown-linux-muslWhoever when I specify the linker, it generates an invalid binary on CI... why cargo build -p rosetta-server-ethereum \
--release \
--target x86_64-unknown-linux-musl \
--config "target.x86_64-unknown-linux-musl.linker='x86_64-linux-musl-gcc'" \
--config "env.CC_x86_64-unknown-linux-musl='x86_64-linux-musl-gcc'" |
|
Finally... |
Lohann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does similar changes as this one https://github.com/Analog-Labs/testnet/pull/272, but also add some metadata to Dockerfiles and removes the requirement of creating the
.cargo/configfile, now all required parameters are defined by the script.Type of change
Tests
For reproduce the issue you need an arm64 device, examples:
Code review prechecks: